by Gemma Lesterhuis.
Hi Jake,
we found the issue!
Appearantly they don't send a 200 response back but a 204 response.
I am not sure if this is something that Moodle should adjust to, but for now we changed the code in lti/classes/local/ltiadvantage/task/sync_grade.php - line 197 to the following.
if ($response['status'] == 200) {
aangepast naar
if ($response['status'] == 200 or $response['status'] == 204) {
If I look up the difference between the 2 status, I can understand why they use 204, but as I said not sure if Moodle should adjust code for this. But I can imagine it should be more flexible.
Please let me know if you want me to create a tracker, making a pull request and sorts becomes to 'developy' for me, I am already happy I sorted this![smile]( "smile")
Gemma
we found the issue!
Appearantly they don't send a 200 response back but a 204 response.
I am not sure if this is something that Moodle should adjust to, but for now we changed the code in lti/classes/local/ltiadvantage/task/sync_grade.php - line 197 to the following.
if ($response['status'] == 200) {
aangepast naar
if ($response['status'] == 200 or $response['status'] == 204) {
If I look up the difference between the 2 status, I can understand why they use 204, but as I said not sure if Moodle should adjust code for this. But I can imagine it should be more flexible.
Please let me know if you want me to create a tracker, making a pull request and sorts becomes to 'developy' for me, I am already happy I sorted this
Gemma