by Jake Dallimore.
Thanks for the info, Gareth. That all looks good to me (nothing jumps out at least).
I know we've had at least one issue with the way this works in the past, so it would also be great to know what Moodle version you're on (sorry, should have asked above). I'll try to explain the issue below in case it's relevant.
The issue was that new window behavior was only working when clicking the activity link on the course home (i.e. where window.open js is present). If you visited mod/lti/view.php page from a link you'd created yourself (and teachers have been known to copy these links around to and fro), then the new window launch didn't work. Of course, this should work either way, and is vital for many tools. This was a bug that came along with the introduction of the LTI 1.3 feature support, iirc (so some time ago now). We patched it in 4.1, but still need to backport that fix to other versions (4.0 the only one in general support now). See MDL-77004 for details of that backport. If you're not on 4.1 or newer, then that bug is still present and might explain what you're seeing.
Of course, you mention that window.open is present in the src, so that may not be the case. The only thing I can think of is that perhaps the js hasn't loaded and that the browser is just following the link, but that's just a guess at this stage.
Cheers
I know we've had at least one issue with the way this works in the past, so it would also be great to know what Moodle version you're on (sorry, should have asked above). I'll try to explain the issue below in case it's relevant.
The issue was that new window behavior was only working when clicking the activity link on the course home (i.e. where window.open js is present). If you visited mod/lti/view.php page from a link you'd created yourself (and teachers have been known to copy these links around to and fro), then the new window launch didn't work. Of course, this should work either way, and is vital for many tools. This was a bug that came along with the introduction of the LTI 1.3 feature support, iirc (so some time ago now). We patched it in 4.1, but still need to backport that fix to other versions (4.0 the only one in general support now). See MDL-77004 for details of that backport. If you're not on 4.1 or newer, then that bug is still present and might explain what you're seeing.
Of course, you mention that window.open is present in the src, so that may not be the case. The only thing I can think of is that perhaps the js hasn't loaded and that the browser is just following the link, but that's just a guess at this stage.
Cheers